search

gpranav88-zz / clothzy-MVP

Clothzy MVP
0 stars 0 forks source link

Which templates are not being / going to be used? #4

Closed agamdua closed 10 years ago

agamdua commented 10 years ago

In the 'cleanup' phase @gpranav88 asked me to do away with any HTML templates that are not being used.

I'm a little confused as to which may be used in future etc, and although git version control prevents us from really losing the files even if I do delete them, just want to double check which ones with you tomorrow before I finalise the 'cleanup' branch.

kartikdhar commented 10 years ago

The ones that are being used: index-test.html productsearch-test.html storesearch-test.html producthome-test.html storehome-test.html reviewerhome-test.html

Rest can be deleted...

Kartik A. Dhar kartik.dhar@gmail.com

On 15 January 2014 00:15, Agam Dua notifications@github.com wrote:

In the 'cleanup' phase @gpranav88 https://github.com/gpranav88 asked me to do away with any HTML templates that are not being used.

I'm a little confused as to which may be used in future etc, and although git version control prevents us from really losing the files even if I do delete them, just want to double check which ones with you tomorrow before I finalise the 'cleanup' branch.

— Reply to this email directly or view it on GitHubhttps://github.com/agamdua/clothzy/issues/4 .

agamdua commented 10 years ago

@kartikdhar, @gpranav88 - Please confirm correct deletion by looking here: https://github.com/agamdua/clothzy/tree/staging/frontend/templates

Fun fact: When The commit message includes something like

Close #4

the Issue automatically gets closed once the pull request is accepted to the default branch, which in our case is 'master' branch. Github Docs explanation.

agamdua commented 10 years ago

Closing since its in staging and confirmed. Reopen with names if there is anything left cc: @kartikdhar @gpranav88