Closed agamdua closed 10 years ago
@gpranav88 @kartikdhar -
This is the working pull request for integrating the new design.
Currently home page & product.html have been updated. Do have a look and let me know if they are working properly.
Command:
$ node dummy.js
Urls to check:
Please tick mark if complete (@kartikdhar - this is mainly for you to check if its rendering according to the new design) or comment if there's a problem.
Also, what to do about reviews section? Delete as discussed? Will this affect your layout?
Kartik A. Dhar kartik.dhar@gmail.com
On 19 January 2014 21:00, Agam Dua notifications@github.com wrote:
Also, what to do about reviews section? Delete as discussed? Will this affect your layout?
— Reply to this email directly or view it on GitHubhttps://github.com/agamdua/clothzy/pull/9#issuecomment-32710806 .
@kartikdhar - Two things
How do I merge these two parts of the templates? Links to lines in both files:
Replacing the p & span in 1 with i tag in 2 makes the phone icon disappear.
Having to do this manually, diffs not working for huge file changes.
What's up with the carousel? Straight copy-paste? Lots going on there.
If you do have time it'll be cool if we can sit and merge these two files together. Can be done remote as well (Screenshare/teamviewer) in case we can't meet today/tomorrow.
The products one was relatively easy to merge which you can see in commit: 4c76f2d. Commit is above on this page in this PR in case you want to see.
Bugs:
Share icons not looking good on product page.
Issue #14 - @kartikdhar handling
Update: Postponing to post-MVP
Icons fixed. Store specific: Perhaps can improve spacing. Also, closed #13 (share icons)
More changes:
Corresponds to #6
2 will be covered in next PR.