gpranav88-zz / clothzy-MVP

Clothzy MVP
0 stars 0 forks source link

Updating new design. #9

Closed agamdua closed 10 years ago

agamdua commented 10 years ago

Corresponds to #6

2 will be covered in next PR.

agamdua commented 10 years ago

@gpranav88 @kartikdhar -

This is the working pull request for integrating the new design.

Currently home page & product.html have been updated. Do have a look and let me know if they are working properly.

Command:

$ node dummy.js

Urls to check:

Please tick mark if complete (@kartikdhar - this is mainly for you to check if its rendering according to the new design) or comment if there's a problem.

agamdua commented 10 years ago

Also, what to do about reviews section? Delete as discussed? Will this affect your layout?

kartikdhar commented 10 years ago

delete all reviews - will have a look at the templates

Kartik A. Dhar kartik.dhar@gmail.com

On 19 January 2014 21:00, Agam Dua notifications@github.com wrote:

Also, what to do about reviews section? Delete as discussed? Will this affect your layout?

— Reply to this email directly or view it on GitHubhttps://github.com/agamdua/clothzy/pull/9#issuecomment-32710806 .

agamdua commented 10 years ago

@kartikdhar - Two things

first problem

How do I merge these two parts of the templates? Links to lines in both files:

  1. New file: https://github.com/agamdua/clothzy/blob/0f3865aa5169c313201d7328ac446cbee5fb4d5f/frontend/templates/StoreHome-test.html#L682
  2. store.html: https://github.com/agamdua/clothzy/blob/0f3865aa5169c313201d7328ac446cbee5fb4d5f/frontend/templates/store.html#L113

Replacing the p & span in 1 with i tag in 2 makes the phone icon disappear.

Having to do this manually, diffs not working for huge file changes.

second problem

Code line: https://github.com/agamdua/clothzy/blob/0f3865aa5169c313201d7328ac446cbee5fb4d5f/frontend/templates/store.html#L113

What's up with the carousel? Straight copy-paste? Lots going on there.

If you do have time it'll be cool if we can sit and merge these two files together. Can be done remote as well (Screenshare/teamviewer) in case we can't meet today/tomorrow.

The products one was relatively easy to merge which you can see in commit: 4c76f2d. Commit is above on this page in this PR in case you want to see.

agamdua commented 10 years ago

Bugs:

agamdua commented 10 years ago

Share icons not looking good on product page. screen shot 2014-01-20 at 5 05 42 pm

Issue #14 - @kartikdhar handling

Update: Postponing to post-MVP

agamdua commented 10 years ago

Icons fixed. Store specific: Perhaps can improve spacing. Also, closed #13 (share icons) screen shot 2014-01-20 at 5 55 11 pm

agamdua commented 10 years ago

More changes:

base.html
product.html

screen shot 2014-01-21 at 6 08 14 pm

store.html

Shifting to next version

home.html