search

gpressutto5 / laravel-slack

:hash: Slack notification for Laravel as it should be. Easy, fast, simple and highly testable.
MIT License
289 stars 41 forks source link

Laravel 5.8 support #15

Closed gpressutto5 closed 4 years ago

gpressutto5 commented 5 years ago

As I said in #13, we need to require laravel/slack-notification-channel@^2.0 for Laravel 5.8 support, but it will break <5.8 support. It would be great if we could specify that this package requires:

illuminate/support >= 5.5 < 5.7
OR
illuminate/support ~5.7.28 AND laravel/slack-notification-channel ^1.0
OR
illuminate/support ^5.8 AND laravel/slack-notification-channel ^2.0
connecteev commented 5 years ago

Thanks @gpressutto5 Is there any way to update the package so that composer require laravel/slack-notification-channel is not needed? Otherwise can we add it to the README / install docs? It'll help others and this took me a while to figure out.

connecteev commented 5 years ago

As an example, this package does not depend on composer require laravel/slack-notification-channel

https://github.com/gahlawat/laravel-slack