djunehor commented 5 years ago

This feature is in response to issue #16 User can now call webhook method on Slack class or facade to specify webhook to use to send a message. Also, removed config array from been required, since default config is also set. We simply take new config keys specified by user and use the default when not specified. Helps write shorter code that way e.g Slack::to('#scientists')->webhook('https://hooks.slack.com/services/XXXXXXXXX/XXXXXXXXX/x00XXXXXXXXX')->send(':thinking_face:');

codecov[bot] commented 5 years ago

Codecov Report

Merging #19 (92d88de) into master (47748bd) will not change coverage. The diff coverage is 100.00%.

@@             Coverage Diff             @@
##              master       #19   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity        28        29    +1     
===========================================
  Files              5         5           
  Lines             73        74    +1     
===========================================
+ Hits              73        74    +1

Impacted Files	Coverage Δ	Complexity Δ
src/Slack.php	`100.00% <100.00%> (ø)`	`14.00 <1.00> (+1.00)`
src/ServiceProvider.php	`100.00% <0.00%> (ø)`	`3.00% <0.00%> (ø%)`
src/Testing/SlackFake.php	`100.00% <0.00%> (ø)`	`7.00% <0.00%> (ø%)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 47748bd...92d88de. Read the comment docs.

djunehor commented 5 years ago

I've made adjustments as requested.

zzt-james commented 3 years ago

Please review this request quickly. I have made and used the same function.

gpressutto5 / laravel-slack

Allow user specify webhook for instance #19

Codecov Report