gprt-org / GPRT

MIT License
22 stars 6 forks source link

Move dependencies to submodules #44

Closed natevm closed 1 year ago

natevm commented 1 year ago

It was requested to move dependencies to submodules to reduce the size of the repository. This is a required to get pull request #27 accepted.

Down the road, we might consider automatically cloning submodules (see https://github.com/gprt-org/GPRT/pull/27#issuecomment-1317638208), but in the past, I've had users like Ingo complain that these autoclone issues make it difficult to develop on the submodule dependencies, since the autocloner reverts the changes to these dependencies on project build.

So for the mean time, I've just updated the readme, and hopefully folks will read that if they run into build issues.

pshriwise commented 1 year ago

It's a valid concern about the autoclone overwriting your work in a submodule. In other projects we've added a CMake variable that turns autocloning off. I'll plan on submitting a follow-on PR to this one with an autoclone option an we can decide if that's sufficient.