search

gpstar81 / GPStar-proton-pack

GPStar Proton Pack and Neutrona Wand
https://www.gpstartechnologies.com
GNU General Public License v3.0
38 stars 9 forks source link

desaturate to white when reaching red #139

Closed gpstar81 closed 1 year ago

DustinGrau commented 1 year ago

I was just looking at this in my own code and was about to try out a quick fix. Instead of the saturation setting, I just made the color value 254 be white (hue: 100, saturation: 0) instead of a separate variable. How does the saturation setting work from the EEPROM menu, do you just keep turning the dial to make the red color lighter?

DustinGrau commented 1 year ago

Code is loaded on my pack and wand but I'm not sure if I've missed something. Turning the dial on menu 4 (for wand) doesn't seem to do anything once I reach red, whether clockwise or counter-clockwise. Does the effect only work in one direction?

gpstar81 commented 1 year ago

I was just looking at this in my own code and was about to try out a quick fix. Instead of the saturation setting, I just made the color value 254 be white (hue: 100, saturation: 0) instead of a separate variable. How does the saturation setting work from the EEPROM menu, do you just keep turning the dial to make the red color lighter?

Yup, keep on turning counter clockwise, you will reach dark red, then it starts to desaturate to pink to white.

gpstar81 commented 1 year ago

Code is loaded on my pack and wand but I'm not sure if I've missed something. Turning the dial on menu 4 (for wand) doesn't seem to do anything once I reach red, whether clockwise or counter-clockwise. Does the effect only work in one direction?

It works counter-clockwise. After reaching the darkest red, then it will begin to de-saturate slowly each turn until you reach pure white.

The plan in the future is to have full saturation control at any colour level, but for now I am leaving it like this. I will need to build a new sub-menu for the EEPROM to handle colour controls I believe. For now though this is good.

DustinGrau commented 1 year ago

I got the wand working--must not have turned the knob enough to make a noticeable change at first. Though think something might be wrong with the inner cyclotron as I saw my colors suddenly change to a desaturated value. I was turning clockwise to go back to purple and somewhere in the middle of the transition I saw it blink and suddenly go a much lighter color. No matter how much I turn I can't get my color back. Perhaps a serial communication glitch reset a value to make it think it should begin altering the saturation instead of the hue?

gpstar81 commented 1 year ago

I got the wand working--must not have turned the knob enough to make a noticeable change at first. Though think something might be wrong with the inner cyclotron as I saw my colors suddenly change to a desaturated value. I was turning clockwise to go back to purple and somewhere in the middle of the transition I saw it blink and suddenly go a much lighter color. No matter how much I turn I can't get my color back. Perhaps a serial communication glitch reset a value to make it think it should begin altering the saturation instead of the hue?

Ooops. Pull the latest bug fix and reflash just the pack again, it should work.

DustinGrau commented 1 year ago

Good catch, that's got it. I ran the full spectrum and saturation for the inner cyclotron and it works now.