search

gpstar81 / GPStar-proton-pack

GPStar Proton Pack and Neutrona Wand
https://www.gpstartechnologies.com
GNU General Public License v3.0
37 stars 8 forks source link

Wand vibration settings not kept after power cycle #323

Closed Toy203 closed 3 months ago

Toy203 commented 3 months ago

The wand vibration settings is kept off regardless of the eeprom settings when the pack battery is turned off and on. I'm on 5.1.2 and can reproduce the issue. Need to get into the eeprom settings again to activate vibration, regardless of the hard switch position.

nomakewan commented 3 months ago

Note this is now the second report of the same exact issue, as we had a user on the FB group report the same.

Is this only on 5.2.1 or does it happen on older firmwares as well?

Toy203 commented 3 months ago

Unfortunately I couldn't test on previous firmware so far.

nomakewan commented 3 months ago

Okay. I will check over the code again to see if there is something obvious. I don't recall us touching any of the vibration-related functions in 5.2.1 but always worth another look.

I will also ask the other user if they are using an Attenuator, as I know you are. If you don't mind, could you test removing your Attenuator cable, then setting vibration options, then power cycling without the Attenuator connected to see if the same bug still occurs?

Toy203 commented 3 months ago

I don't have an attenuator installed, only the ESP inside the pack actually.

nomakewan commented 3 months ago

My mistake, though they operate identically I understand it would be much more difficult for you to test removing it since you would have to reopen the pack. I will stick to just reading the code to try to locate the issue, then. Thank you.

nomakewan commented 3 months ago

I have located some potential issues with how vibration is handled, though those issues did not start in 5.2.1. Perhaps they just weren't noticed until now.

PR is now open at #324 . If you get a chance to open your pack and wand to update, please do see if the included binaries resolve this issue for you.

Toy203 commented 3 months ago

Fixed with 5.2.2