search

gpstar81 / GPStar-proton-pack

GPStar Proton Pack and Neutrona Wand
https://www.gpstartechnologies.com
GNU General Public License v3.0
37 stars 8 forks source link

Quick vent pump stops early #326

Closed Toy203 closed 2 months ago

Toy203 commented 3 months ago

I've set a longer overheat duration for level 5, 30 secs, since I plan to use quick vent when I roam around. . The quick vent feature correctly turns on the leds for the half time duration as expected when engaged, but the pump stops after 4-5 seconds.

nomakewan commented 2 months ago

The pump stopping after 4 seconds is intentional. The bug is actually that your quick vent does a duration longer than 4 seconds.

I see where the bug is (it was just a reversed inline conditional while setting the timer) and this will be corrected for 5.3.0.

Toy203 commented 2 months ago

So i'll still be able to set up a longer overheat sequence to get half of that duration quick vent feature with pump action, fan spin and leds, correct?

nomakewan commented 2 months ago

That was not the intention of the video game quick vent feature. It was just supposed to be a rapid vent like in the game, and so the original intent was to have it top out at 4 seconds.

For people who just wanted to show off smoke, that's why the "long press" quick vent was implemented that forces the full overheat sequence.

Toy203 commented 2 months ago

Ah i see, this is a bit unfortunate. I really preferred to be able to trigger just the smoke effects with custom duration while roaming around during events, without triggering all the overheat alarms etc.

nomakewan commented 2 months ago

Well, it can always be changed. If someone's requesting it, I have no reason to reject that change request. It's a bug either way, just depends on which side of the calculation you want to call wrong.

I'll change it so it's duration / 2 on everything for you.

EDIT: Fixed in #325