search

gpstar81 / GPStar-proton-pack

GPStar Proton Pack and Neutrona Wand
https://www.gpstartechnologies.com
GNU General Public License v3.0
37 stars 8 forks source link

Cyclotron lid slime mode not working #333

Closed Rizzbuster closed 2 months ago

Rizzbuster commented 2 months ago

Cycling lid issue. Tested all the year modes and slime mode is not working. I did get continuing fire at one point but can't pin point how it happened yet.

Toy203 commented 2 months ago

Can reproduce, no lights in the circles on Slime mode. I got 9 led pucks mounted. Also, in Slime mode (AF) my power cell is still running once i turn off the pack from the ion arm or wand.

DustinGrau commented 2 months ago

From reports, one user is on the stock lights, another on Frutto, so this is not immediately related to RGB vs. standard.

nomakewan commented 2 months ago

Found the issue. It's so stupid as to be unreal.

nomakewan commented 2 months ago

So to fix the issues with ramp speeds not being correct if you boot the Proton Pack in Slime and then switch firing modes (or recover from overheat in slime and switch firing modes), I moved the call to the slime lights into the actual cyclotron control loops. The problem is I forgot there was a call that skips those control loops entirely if we're in slime mode.

Fixed now.

nomakewan commented 2 months ago

Can reproduce, no lights in the circles on Slime mode. I got 9 led pucks mounted. Also, in Slime mode (AF) my power cell is still running once i turn off the pack from the ion arm or wand.

Please test the new binary on your pack to see if it resolves all of these issues. If it does, awesome. If not, that lets us know to keep looking into the power cell and vibration stuff.

Toy203 commented 2 months ago

Sorry, no luck. Same behaviour as before both for cyclotron ring and power cell. Should i erase eeprom and try?

nomakewan commented 2 months ago

Sorry, no luck. Same behaviour as before both for cyclotron ring and power cell. Should i erase eeprom and try?

Erasing EEPROM has not been necessary since 5.0.0. It will have no effect here since the issue is with code, not EEPROM settings.

I will see what else I can do to work this out.

nomakewan commented 2 months ago

Sorry, no luck. Same behaviour as before both for cyclotron ring and power cell. Should i erase eeprom and try?

Okay, new binary is pushed (it has the same URL as above). Please test this one.

Toy203 commented 2 months ago

Looks like both problem are fixed with this! Tried also in 84/89, no issues. Cyclotron lights up and no more power cell going after shutdown.

nomakewan commented 2 months ago

@Rizzbuster See if everything is good on your end as well. If so, we can consider this issue Busted!