gpstar81 / GPStar-proton-pack

GPStar Proton Pack and Neutrona Wand
https://www.gpstartechnologies.com
GNU General Public License v3.0
37 stars 8 forks source link

[Bug]: quick vent pump still not going full time #346

Closed Toy203 closed 1 month ago

Toy203 commented 1 month ago

What actions were attempted?

I extended the Overheat time in eeprom to have a decently long quick venting action (should be around 10 sec once halved). My goal is to be able to trigger a smoke event without the alarm and light slowing down.

What actually happened?

I can hear the pump going for a couple of seconds, but then it stops. Fans and lights keep going correctly during the whole sequence of quick vent.

What was expected?

The pump should keep going up until the quick vent status ends.

Firmware Version

5.3.1

Mode in Use

Super Hero / Video Game

Notable Hardware

Wasteland smoke kit

Homework Completed

nomakewan commented 1 month ago

To be clear, do you have "Overheat sync to fan" enabled or disabled? I can see where this bug might be, but it all depends on how you have that setting configured.

As a bonus if you'd like to see what happens when you switch that setting to the opposite of what you have right now and report back how it behaves, that would be very cool.

Toy203 commented 1 month ago

It was disabled and with that settings it does like above. If i enable synch, looks like quick vent works as intended.

nomakewan commented 1 month ago

Found the actual real problem. I made a silly typo. Teehee. I think if you test Power Level 1 with "overheat sync to fan" disabled you'll find it works normally, just not in any other power level.

Fixed for 5.3.2.

Toy203 commented 1 month ago

Pack is currently open for maintenance and updating (boy, that new amplifier is good) so i trust your word on this. Keep up the good work guys!