search

gpstar81 / GPStar-proton-pack

GPStar Proton Pack and Neutrona Wand
https://www.gpstartechnologies.com
GNU General Public License v3.0
38 stars 8 forks source link

Disable inner cyclotron switch panel LEDs while brass pack mode is running #358

Closed ProtonCharging closed 3 months ago

ProtonCharging commented 3 months ago

What would you like to add in terms of software changes?

The Option of Disabling the Internal Panel Lights without disconnecting any JST connectors. Could take up a spot in the LED menu if there's room, or be a third selection for the panel option on EEPROM LED menu level 2?

Would this request involve any specific hardware?

Inner Cyclotron LED Kit (Old and Updated)

Homework Completed

Toy203 commented 3 months ago

Out of curiosity, why disable it?

nomakewan commented 3 months ago

Have to agree here. What is the use case?

Implementing it would be trivial for v6 (see #345 ) but I'm curious as to why.

ProtonCharging commented 3 months ago

I'm using the fairy lights on my proton pack to try and replicate the sparking pack's look. Ends up getting drowned out by the panel lights on the top left, and I don't wanna remove them since it'd end up just being a waste of money for me.

nomakewan commented 3 months ago

See now that actually makes sense. I'll go ahead and get this into 5.3.3 as a bugfix, and for v6 it can be turned into an option.

nomakewan commented 3 months ago

Fix has been implemented and will be a part of 5.3.3 as planned.

ProtonCharging commented 3 months ago

Just updated to 5.3.3, are the left two lenses by the switches supposed to still be lit? If so, is it possible to have those two go dark during the brass pack mode too? I wanna get as much spark light as I can. Thanks :)

nomakewan commented 3 months ago

Those two are the mode indicators for year and vibration.

Yes, I can have them turn off as well.

ProtonCharging commented 3 months ago

That'd be great, thank you!