search

gpstar81 / GPStar-proton-pack

GPStar Proton Pack and Neutrona Wand
https://www.gpstartechnologies.com
GNU General Public License v3.0
38 stars 8 forks source link

Halloween Spectral Swap #368

Closed Aces6469 closed 2 months ago

Aces6469 commented 3 months ago

What would you like to add in terms of software changes?

Kinda surprised I haven't seen anyone ask it yet, but possibly an LED setting that changes the colors of the christmas mode to purple and orange for Halloween?

Would this request involve any specific hardware?

Frutto Powercell, 5 or 9 LED PCBs.

Homework Completed

DustinGrau commented 3 months ago

This does actually exist, it's just not exposed as an option. I started to add some other color combos as I figured people may want sports team colors or other holidays, namely Halloween. So the ability isn't far off, just not made into a user preference.

DustinGrau commented 3 months ago

Look at https://github.com/gpstar81/GPStar-proton-pack/blob/main/source/ProtonPack/Colours.h C_ORANGEPURPLE was intended to do just this thing

nomakewan commented 3 months ago

Yep, it's been in the code since literally forever. We just have to figure out some way to select which holiday and it'll be good to go.

If you have any suggestions on how to switch between Christmas and Halloween for the Holiday mode, we're all ears!

Aces6469 commented 3 months ago

Could use the wing button at the end of the thrower? Last I recall it does nothing in the spectral modes with all toggles up.

nomakewan commented 3 months ago

And so the solution presents itself instantly. Gonna go ahead and assign this to myself and get it ready for 5.3.4.

nomakewan commented 2 months ago

Holiday modes for both Christmas and Halloween are now fully implemented and will be in the 5.3.4 release. Thank you for your suggestions!