search

gpstar81 / GPStar-proton-pack

GPStar Proton Pack and Neutrona Wand
https://www.gpstartechnologies.com
GNU General Public License v3.0
38 stars 8 forks source link

[Bug]: Non-addressable barrel LED not flashing during entire firing sequence on Single Shot #372

Closed nomakewan closed 2 months ago

nomakewan commented 2 months ago

What actions were attempted?

Fire the Single Shot wrist blaster.

What actually happened?

The BARREL LED flashed once at the end of the firing sequence.

What was expected?

The BARREL LED should flash through the entire firing sequence.

Firmware Version

5.3.3

Mode in Use

Any / Both Modes

Notable Hardware

Single Shot Wrist Blaster with non-addressable barrel LED.

Homework Completed

DustinGrau commented 2 months ago

Arguably this isn't a bug, the idea was to always use addressable LEDs. Michael has a new version on the way that will be usable for both the single lens cyclotron and the barrel, allowing us to use colors for the effect. I thought I had left the W-LED port active but there may have been a timer removed that manages that. It's not a high priority and the device is not officially a kit, so behaviors are neither set in stone nor guaranteed.

nomakewan commented 2 months ago

You did leave it active; but your firing uses a lot of the semi-automatic code. In the semi-automatic firing modes, the barrel tip LED only illuminates when the pulse finishes traveling up the barrel. But in this case, there is no barrel, so the code controlling the BARREL LED port needs to be modified to flash throughout the pulse sequence rather than only flashing once at the very end.