search

gpstar81 / GPStar-proton-pack

GPStar Proton Pack and Neutrona Wand
https://www.gpstartechnologies.com
GNU General Public License v3.0
38 stars 9 forks source link

[Bug]: System volume decreases during venting #406

Open DustinGrau opened 1 month ago

DustinGrau commented 1 month ago

What actions were attempted?

Manually trigger a vent sequence or fire a stream long enough to go into overheat.

What actually happened?

This one I noticed myself so logging a bug to make sure I remember to revisit it, but also inform others that it might be occurring. While either manually venting or entering an overheat sequence I noticed the system overall volume being reduced without any interactions on my part. I could see the % change on the web UI so it wasn't just me hallucinating or thinking it was something else. I manually had to turn up the volume after the venting to get it back to normal.

What was expected?

Did not expect volume to randomly change without interaction.

Firmware Version

5.4.2 (technically 6.0 Beta 2)

Mode in Use

Super Hero / Video Game

Notable Hardware

Running all the latest version boards, modified Wasteland smoke kit via relay.

Homework Completed

nomakewan commented 4 weeks ago

Looking into this, there are only two possibilities.

  1. Somehow, the check HERE is going wonky-doodle. This is impossible while firing, but since I do not know how you are initiating your overheat sequences out in the field I cannot discount it. The check will prevent this volume control from working if either of the right-hand switches are in the 'on' position. However, I bring it up because it works by holding down Intensify, and holding down Intensify is what does the manual overheat sequence in Mode Super Hero as well (albeit with the bottom-right switch on and the top-right switch off).

  2. Somehow, the rotary encoder on the Attenuator is going wonky-doodle. There are no guards on the rotary encoder's volume control other than if the wand is currently firing and the current multiplier is greater than 2 (at which point it will function as the stream attenuator rather than the volume control). This can be seen HERE. This means that when firing and the multiplier is 0~2, it will continue to act as a volume control. It will also act as volume control while the ribbon cable alarm is going off, and while overheating, and while venting, and while wand mashing, and..............you get the point.

Personally 2 seems more likely. Perhaps the guards on the volume control need to be made more robust, and the actual functionality of the rotary encoder itself should be inspected to make sure no errant signals are being passed along as turns.