gptscript-ai / desktop

MIT License
19 stars 13 forks source link

UI - Make search tool results in "Tool catalog" page more reliable. #116

Closed sangee2004 closed 6 days ago

sangee2004 commented 1 month ago

I am not able to reliably get tool search to return tools I am looking for.

In case of searching for "digital ocean" , no tool gets returned

Screenshot 2024-08-11 at 1 40 21 PM

When searching for "eks" , I see only Eksctl returned and not "Amazon EKS"

Screenshot 2024-08-11 at 1 43 00 PM

I am not able to get search results even for "Amazon EKS".

Screenshot 2024-08-11 at 1 44 52 PM

Other times like this , I have seen it work as expected (with contains search criteria and search being case insensitive)

Screenshot 2024-08-11 at 1 44 22 PM
tylerslaton commented 1 month ago

@g-linville I believe you are currently working on this so assigning to you.

sangee2004 commented 3 weeks ago

The search queries mentioned in the issue still do not result in fetching the tools as expected.

I also cant find any of the tools under productivity when searching for them using their names as well. I was under the impression that anything that was listed in the tools view by default are all the featured ones and they should be searchable .

When I searched forinternet , i got duckduckgo entry which should not be presented ? This repo is archived,readonly and private.

I get this error when trying to load the assistant with this tool

"failed to load program: failed resolving github.com/gptscript-ai/question-answerer/duckduckgo from ./inline: failed to get GitHub commit of gptscript-ai/question-answerer at HEAD (fallback error exit status 128: remote: invalid credentials\nfatal: Authentication failed for 'https://github.com/gptscript-ai/question-answerer.git/'\n): 404 Not Found {\"message\":\"Not Found\",\"documentation_url\":\"https://docs.github.com/rest/commits/commits#get-a-commit\",\"status\":\"404\"}"
sangee2004 commented 1 week ago

When testing with the latest build - 9d4616691 , I am able to see the search results in Tool Catalog page fetch the right entries , but the name with which they get displayed is very misleading.

This is true for many entries in the featured list which have read/write versions of the tools.

Searching for mail will show 2 entries "Manage" and "Read" which is very confusing

Screenshot 2024-09-04 at 4 10 50 PM

This is when slack is searched:

https://github.com/user-attachments/assets/0dc2dfb5-1fdf-411c-a5c3-8c81b6ddb165

sangee2004 commented 1 week ago

Search in the tool catalog page which gets launched from "Edit Assistant" page lets us search for other tools that are not in the feature list . This should not be the case -https://github.com/gptscript-ai/desktop/issues/248#issuecomment-2330339732.

cjellick commented 6 days ago

We're addressing this by completely removing tool site search from the app.

The only piece that was concerning me was this:

When I searched for internet , i got duckduckgo entry which should not be presented ? This repo is archived,readonly and private.

but i cannot reproduce it

sangee2004 commented 6 days ago

When searching for internet we get only Answers From The Internet now.

Closing this issue since issue mentioned in https://github.com/gptscript-ai/desktop/issues/116#issuecomment-2330303837 and https://github.com/gptscript-ai/desktop/issues/116#issuecomment-2330354636 should be addressed with theremoving tool site search from the app.