search

gptscript-ai / desktop

MIT License
22 stars 13 forks source link

Chat does not quit when using `sys.chat.finish` and instead gives this message - "Calling tool chatFinish..." when used in "--ui" option. #124

Open sangee2004 opened 5 months ago

sangee2004 commented 5 months ago

Steps to reproduce the problem:

  1. Launch UI using - GPTSCRIPT_CHAT_UI_TOOL=github.com/gptscript-ai/ui@v2 gptscript --ui

  2. Execute the following script that uses sys.chat.finish

    
chat: true
tools: github.com/gptscript-ai/search/duckduckgo,  sys.chat.finish

This is a chatbot. Finish the chat when users type bye or quit.



3. Chat with this script and once done type "quit" to exit

This does not result in chat session closing and instead gives this message - "Calling tool chatFinish..." 

<img width="1238" alt="Screenshot 2024-06-10 at 1 11 40 PM" src="https://github.com/gptscript-ai/gptscript/assets/122560863/b3c622e1-a0b4-4097-86d4-3fb7da63ec99">

Expected Behavior:
We should be able to close the existing chat session in this case.
tylerslaton commented 3 months ago

@cjellick What do we want to happen here? This issue is old so may be no longer relevant with the current design decisions. I would expect assistants through the UI to not include this tool as I'm thinking about it.

cjellick commented 3 months ago

im double checking exact expecations of the finsih tool with darren

tylerslaton commented 3 months ago

@cjellick Any updates on that check?

cjellick commented 3 months ago

Finish tool is only useful in multi agent scenarios which are out of scope of anything we should be testing now.

tylerslaton commented 3 months ago

Cool. I guess we should still keep this open then?