gptscript-ai / desktop

MIT License
19 stars 13 forks source link

Undefined tool name in StackTrace view. #129

Open sangee2004 opened 3 months ago

sangee2004 commented 3 months ago

Steps to reproduce the problem:

  1. Launch UI using - GPTSCRIPT_CHAT_UI_TOOL=github.com/gptscript-ai/ui@v2 gptscript --ui

  2. Execute the following script that uses credentials:

chat: true
description: This a search chatbot.
tools: github.com/gptscript-ai/search/duckduckgo,  sys.chat.finish

This is a chatbot. Finish the chat when users type bye or quit.
  1. Chat with the script to get some information from web.
  2. Use "View Stack Trace" option .
Screenshot 2024-06-10 at 3 55 37 PM

Notice that the tool name appears as "undefined" in stack trace text.

njhale commented 2 months ago

@sangee2004 not getting this issue anymore with main of the UI tool.

Could you try again to see if you're still encountering it?

tylerslaton commented 2 months ago

I fixed this in a commit awhile ago but it looks like it slipped through the cracks of me updating issues. Thanks @njhale. Nick's correct @sangee2004 you should no longer see this.

sangee2004 commented 2 months ago

@tylerslaton @njhale I tested with gptscript version v0.9.2+0f32a9d8

I dont see Loaded Undefined anymore instead I see Ran [object Object] in Calls section. which also is not providing any info to the user.

We expect to see tool name instead ? We have the tool name in Messages section already.

Image

I will retest with build from main in a bit.

I see the same behavior when testing on main - gptscript version v0.0.0-dev-daef472e-dirty as well when launching ui -gptscript --disable-cache --ui testchatfinish.gpt .

njhale commented 2 months ago

@tylerslaton is that [object Object] supposed to be a tool name?

tylerslaton commented 2 months ago

@tylerslaton is that [object Object] supposed to be a tool name?

Yep, looks like it's an edge case I didn't catch. We can keep this open to track that.