gptscript-ai / desktop

MIT License
22 stars 13 forks source link

Not able to continue to chat in the thread after denying the confirm prompt for running tool call #179

Closed sangee2004 closed 1 month ago

sangee2004 commented 2 months ago

Electron build from commit id - 1eeb6f0161e8

Steps to reproduce the problem:

  1. Create an assistant with Trello tool call
  2. Chat this is assistant.
  3. When presented with following prompt, deny it Screenshot 2024-08-16 at 10 48 49 AM
  4. Following error is presented to the user: Screenshot 2024-08-16 at 10 42 20 AM
  5. After this we are not able to chat and get any response Screenshot 2024-08-16 at 10 43 03 AM
cjellick commented 1 month ago

havent been able to repro. can you retest

sangee2004 commented 1 month ago

@cjellick I am able to reproduce the issue noted in the bug.

I think what might not have been obvious here is that when I am asked to "Restart Scipt" in step 4 , I am not restarting the script. I am just asking questions to the LLM which does not involve Trello tool and expected it to succeed which was not the case.

https://github.com/user-attachments/assets/f99be462-3256-4c1c-b694-9115295ff802

cjellick commented 1 month ago

Ok. Does this only occurr with trello?

If it is trello specific, im going to deprioritize it as i'll be taking trello out of the catalog because overall it is not very good and not critical to our primary usecase.

sangee2004 commented 1 month ago

With tools like outlook which has oauth workflows , there is no confirm/deny prompt during the authentication process. If i choose to not take any action for the sign in process and start other conversations with LLM , i get the same behavior of not getting any response.

Image

thedadams commented 1 month ago

The issue here is that it is not obvious that the application is waiting for you to respond to the prompt. I am changing this so that you cannot enter more messages when the app is waiting for a response to a prompt or confirmation.

Screenshot 2024-09-03 at 12 15 41
thedadams commented 1 month ago

PR: https://github.com/gptscript-ai/desktop/pull/398

sangee2004 commented 1 month ago

Tested with build from 9d46166919

This issue is not reproducible anymore. User is not allowed to enter any text when app is waiting for a response to a prompt or confirmation.