search

gptscript-ai / desktop

MIT License
22 stars 13 forks source link

Confirm setting #467

Closed tylerslaton closed 1 month ago

tylerslaton commented 1 month ago

This PR does two things.

  1. It adds a new settings.json file where app settings live. It aggregates the old browsersettings.json file that previously existed while allowing for new ones to come through.
  2. There is a new setting, Tools Require Comfirmation. It is disabled by default and toggles confirm call functionality.
Settings page ![Screenshot 2024-09-09 at 2 09 10 PM](https://github.com/user-attachments/assets/1c7c2fb8-d919-4696-bc87-5fdfad4a2f1e)
Demonstration https://github.com/user-attachments/assets/6c74f79b-3401-4d96-9481-4af2a2190083

431

tylerslaton commented 1 month ago

@StrongMonkey @g-linville Re-requesting review from you as well just because this changed a bit based on Ryan's suggestion. We now have a settings context which will allow everywhere in the app to see or save settings easily.