gptscript-ai / desktop

MIT License
22 stars 13 forks source link

fix: fix app.mjs panic and create settings.json on startup #481

Closed tylerslaton closed 2 months ago

tylerslaton commented 2 months ago

There were some issues that were not caught in the last PR because a lot of the reviewers already had settings files. I didn't catch it while programming the settings page up for the same reason, to fix this this PR does 3 things.

  1. The socket server now will use default settings if the settings file does not exist. This shouldn't happen, but just in case. This was an issue because of...
  2. Create the settings.json file in the correct place, it was previously in the workspace dir which was incorrect. We now also only create it if it doesn't already exist.
  3. Fixes an issue where the users could not set browser settings persistently. (noticed while fixing the root issue, but was not a cause of the root issue).

480

https://acorn-io.slack.com/archives/C03FU91U4SX/p1725985732395979