gptscript-ai / desktop

MIT License
22 stars 13 forks source link

Knowledge - Able to chat with deleted knowledge files in existing threads. #519

Open sangee2004 opened 2 months ago

sangee2004 commented 2 months ago

Electron build - d27f9f

Steps to reproduce the problem:

  1. Create an assistant
  2. Add multiple (at least 2) knowledge file say file1 and file2 using "Add Local Files"
  3. Chat with the assistant about one of knowledge file say file1.
  4. Edit the assistant and remove file1.
  5. Start a new chat with the assistant about the delete knowledge file -file1. This will not be able to fetch any information as expected
  6. Continue to chat in existing thread (from step3) about delete knowledge file .

User will continue to get information about the deleted knowledge file.

Expected Behavior: User should not get any information about the deleted knowledge file even in existing threads.

cjellick commented 2 months ago

Is the information coming from queries to the knowlege api or from the context that had been built up? If it's from the context that's been built-up, then thats expected

sangee2004 commented 2 months ago

When I tested the same scenario again, I was not getting the information from the deleted knowledge files when tool call was made to knowledgeRetrieval tool. When I see the behavior mentioned in the issue , it is from the Knowledge Retrieval Context