gptscript-ai / desktop

MIT License
22 stars 13 forks source link

UI - Not able to load threads that are associated with deleted assistants. #96

Closed sangee2004 closed 2 months ago

sangee2004 commented 2 months ago

Electron app build wit commit id- 4414471

Steps to reproduce the problem: Pre Req - set DISABLE_CACHE=true

  1. Launch electron app using npm run dev:electron
  2. Create an assistant.
  3. Run the assistant and have a chat with this assistant.
  4. Delete the assistant created in step 1.
  5. Access the thread that was created in step1. Notice that thread is not getting loaded and stuck in this state for ever:
Screenshot 2024-08-07 at 10 50 12 AM
cjellick commented 2 months ago

Would like it to just say "Assistant not found"

thedadams commented 2 months ago

PR: https://github.com/gptscript-ai/desktop/pull/61

sangee2004 commented 2 months ago

Tested with Version - 0.10.0-rc1 (0.10.0-rc1) (Release build)

I am still able to reproduce this issue

  1. Create an assistant.
  2. Run the assistant and have a chat with this assistant.
  3. Delete the assistant created in step 1.
  4. Access the thread that was created in step2.
  5. Notice that thread is not getting loaded and stuck in "Loading your assistant..." state for ever.
thedadams commented 2 months ago

Currently, I am not able to reproduce this behavior. I am presented with this screen instead of step 5. Screenshot 2024-08-12 at 07 32 06

sangee2004 commented 2 months ago

Tested with fresh install of 0.10.0-rc1 builds. This issue is addressed.

We see the following screen as expected when opening chat thread with assistants that was deleted.

Screenshot 2024-08-12 at 11 03 06 AM