search

gpu / JOCL

Java bindings for OpenCL
http://www.jocl.org
Other
187 stars 33 forks source link

Code quality improvements - squid:S00115, squid:S106, squid:S1213 #8

Closed georgekankava closed 8 years ago

georgekankava commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rules squid:S00115 - Constant names should comply with a naming convention. squid:S106 - Standard outputs should not be used directly to log anything. squid:S1213 - The members of an interface declaration or class should appear in a pre-defined order. This pull request removes technical debt of 135 minutes. You can find more information about the issue here: https://dev.eclipse.org/sonar/rules/show/squid:S00115 https://dev.eclipse.org/sonar/rules/show/squid:S106 https://dev.eclipse.org/sonar/rules/show/squid:S1213 Please let me know if you have any questions. George Kankava

gpu commented 8 years ago

The other changes seem OK. The habit of placing the private constructor at the bottom is not important. And replacing the System.err output with a log output is OK (even though that if someone ever receives this message, something must be severely messed up anyhow...)

georgekankava commented 8 years ago

I will put the private constructor back where it was.

gpu commented 8 years ago

To avoid misunderstandings: It's okay to move it to a place where Sonar does not complain. I mean that I hardly care where it is. (I'm just habitually placing it at the bottom, but it can be anywhere...)

georgekankava commented 8 years ago

@gpu Thanks. PR updated.

gpu commented 8 years ago

Thanks again!