search

gpufit / Gpufit

GPU-accelerated Levenberg-Marquardt curve fitting in CUDA
MIT License
309 stars 91 forks source link

Different constraints for every fit (Fix #105) #117

Closed jimkring closed 1 year ago

jimkring commented 1 year ago

I've made the proposed change mentioned here in Issue https://github.com/gpufit/Gpufit/issues/105, adding the missing fit_index * n_parameters factor needed when indexing into the constraints array.

jimkring commented 1 year ago

@superchromix @adrianjp88 If you can, please take a look at this PR and let me know if the code looks correct. We tried to test (after my last change to GPUData::init to write constraints at the current chunk) and are now getting an invalid input/argument error when trying to pass constraints for each fit. Thanks!

gpufit commented 1 year ago

This bug should be fixed in c65c867b4528ddbf3ed6af6428f589fb93fb972d. Thanks for looking into this.

jimkring commented 1 year ago

Fantastic! Thanks for your assistance getting this fixed @gpufit