gpujs / gpu.js

GPU Accelerated JavaScript
https://gpu.rocks
MIT License
15.1k stars 652 forks source link

Remove trailing commas #665

Closed evanakm closed 3 years ago

evanakm commented 3 years ago

Fix for https://github.com/gpujs/gpu.js/issues/589

For an Angular 7.1 project, the prod build doesn't work, and it is caused by terser at the backend. Specifically the issue described here:

terser/terser#412

There are several examples in GPU.js of result.push('foo','bar','quux',) (note the trailing comma). These need to be removed. I have manually removed them in my local copy of the package (in dist/gpu-browser.js and dist/gpu-browser-core.js) and it builds. These seem to come from several of the source files in the back end. It should be an easy fix.

robertleeplummerjr commented 3 years ago

Released in https://github.com/gpujs/gpu.js/releases/tag/2.11.2