search

gpul-org / XEA

0 stars 0 forks source link

Convert JWT-Knox into a ViewSet #7

Closed ssaavedra closed 8 years ago

ssaavedra commented 8 years ago

This converts the different APIViews that formed the JWT-Knox app into a single ViewSet.

The advantages of this approach are: less code repetition (although we managed to avoid some by subclassing the APIView in the first place), and the use of a router, which may aid the SchemaGenerator when we generate an API self-description to know that several endpoints are related to the same API behaviour.

ssaavedra commented 8 years ago

WARNING: In the current state, this does not pass the defined tests. Those need to get updated to work with the ViewSet.

ssaavedra commented 8 years ago

Now the tests should pass, but I want to squash the commits before doing the merge. The commits are now spread so that they are easier to inspect. If it looks good to you, I'll squash them for the merge.

cc/ @castrinho8 ¿a quien más hago ping?

therealtod commented 8 years ago

lgtm

ssaavedra commented 8 years ago

LGTM