Pull request 29.06.2021

[Mike-de-bike]

Hi Gabriel,

Here we go.

Regards Stefan

[gpulido]

Great!, good work. First question: This is for an Aidoo system or for a machine / zones configuration? From your code I can understand that the machine manages all of them. If it is a multiple zone configuration, we should abstract into Machine and Zone. What do you think?

Also you should install the "pre-commit" package:

pip install pre-commit
$ pre-commit install

As I have added some pep checks and spellers.

[Mike-de-bike]

Hi Gabriel,

it is so much for me working on it. 😀👍

It is not for aidoo, but for a direct machine config.

For a quick overview of my device AZEZ6DAIST07 (M5/L5): the machine / device is the controlling instance (zone 0). The device has got 5 dampers (actuators), each correspondents to a zone (1-5). The machine can only work (operation mode) in one mode, heating, drying, stop, ventilating or cooling, so do all the zones then.

zone0-methods: 1.  on/off

2. Operation mode
3. Fan speed

The zone1-x-methods:

1. TempMax
2. TempMin
3. CoolSetpoint
4. HeatSetpoint
5. On/off
6. Naming

⁣greetings Stefan

Am 29. Juni 2021, 11:03, um 11:03, Gabriel Pulido @.***> schrieb:

Great!, good work. First question: This is for an Aidoo system or for a machine / zones configuration? From your code I can understand that the machine manages all of them. If it is a multiple zone configuration, we should abstract into Machine and Zone. What do you think?

Also you should install the "pre-commit" package:

pip install pre-commit
$ pre-commit install

As I have added some pep checks and spellers.

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/gpulido/python-airzone/pull/8#issuecomment-870415461

[gpulido]

Changed the base branch to be localapi and a lot of refactor applied to the @Mike-de-bike pr. I close this as it is oldated.