search

gpuweb / cts

WebGPU Conformance Test Suite
https://gpuweb.github.io/cts/
BSD 3-Clause "New" or "Revised" License
130 stars 82 forks source link

op: shader_module,compilation_info with utf16 messages #2266

Open austinEng opened 1 year ago

austinEng commented 1 year ago

Expand tests in compilation_info.spec.ts to include error messages that contain utf16 code points. Like Error: unknown function 'hello👩‍💻'

kainino0x commented 1 year ago

Can be added to api/validation/shader_module/entry_point.spec.ts, I think

greggman commented 1 year ago

What's required here? IIUC there's no spec about what messages get returned, only that if they are returned, I'd be nice (but not guaranteed) if line and column were correct.

In other words, impl can return no error message, or Error: unknown function or just Error

kainino0x commented 1 year ago

Test could warn if it's not included. That's not a failure by default and won't be very useful but someday we might run CTS with a "-Werror" style mode.

Also would be useful to know nothing crashes with these inputs, but we may have that tested sufficiently well already, not sure.