note: I wasn't sure if I should make stringToType take a keyof Type instead of string. I'm not even sure that would make and if I should add vec4<f32> to Type etc... As it's, without stringToType you can not round trip because Type.vec4f serializes to vec4<f32> but there is no Type['vec4<f32>']. I was also worried about how many places I'd have to coerce strings into keys of Type. I feel like the assert covers it.
Requirements for PR author:
[X] All missing test coverage is tracked with "TODO" or .unimplemented().
[X] New helpers are /** documented */ and new helper files are found in helper_index.txt.
[X] Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
[X] Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)
textureGather and textureGatherCompare
Also, added missing types to existing tests.
Issue: #3586 #3594
note: I wasn't sure if I should make
stringToType
take akeyof Type
instead of string. I'm not even sure that would make and if I should addvec4<f32>
toType
etc... As it's, withoutstringToType
you can not round trip becauseType.vec4f
serializes tovec4<f32>
but there is noType['vec4<f32>']
. I was also worried about how many places I'd have to coerce strings into keys ofType
. I feel like theassert
covers it.Requirements for PR author:
.unimplemented()
./** documented */
and new helper files are found inhelper_index.txt
.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.