Closed greggman closed 5 months ago
Is src/resources/cache/webgpu/shader/execution/bitcast.bin
related to this cl or leftover from something else?
is src/resources/cache/webgpu/shader/execution/bitcast.bin related to this cl or leftover from something else?
It's what happens when I run npm run test
. If I don't check it in then github complains that it changes when it does its own npm run test
and finds that files changed.
This kind of thing happens all the time to me and is one of the reasons people complain that the .bin files and hashes.json need to be generated github actions and checked into a different branch and have dawn pull that branch instead of having them in main
and always causing these issues.
Unfortunately that would have other issues. Like a test roll with a git url and commit hash wouldn't work (as is) because those files would be missing. Of course maybe we could get the test roll to generate those files.
textureGather and textureGatherCompare
Also, added missing types to existing tests.
Issue: https://github.com/gpuweb/cts/issues/3586 https://github.com/gpuweb/cts/issues/3594
Requirements for PR author:
.unimplemented()
./** documented */
and new helper files are found inhelper_index.txt
.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.