shader/validation: Move `break if` expression type validation out of `parse` - Githubissues

gpuweb / cts

WebGPU Conformance Test Suite

https://gpuweb.github.io/cts/

BSD 3-Clause "New" or "Revised" License

121 stars 72 forks source link

shader/validation: Move `break if` expression type validation out of `parse` #3671

Closed ben-clayton closed 2 months ago

ben-clayton commented 2 months ago

Use the same pattern by the other statement validation tests.

Requirements for PR author:

[x] All missing test coverage is tracked with "TODO" or .unimplemented().
[x] New helpers are /** documented */ and new helper files are found in helper_index.txt.
[x] Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
[x] Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

[ ] Tests are properly located in the test tree.
[ ] Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
[ ] Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
[ ] Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

ben-clayton commented 2 months ago

Also adds testing for abstract types.