gpuweb / cts

WebGPU Conformance Test Suite
https://gpuweb.github.io/cts/
BSD 3-Clause "New" or "Revised" License
121 stars 72 forks source link

Test that submit validates command buffers uniqueness #3699

Closed toji closed 2 months ago

toji commented 2 months ago

Issue first raised in https://github.com/gpuweb/gpuweb/issues/4367 with proposed validation behavior added to the spec in https://github.com/gpuweb/gpuweb/pull/4593. This PR should probably not land until that spec change has landed.

Ensures that command buffers are validated for uniqueness when submitting. Prevents an edge case which may allow command buffers to be submitted twice.

This behavior is not yet implemented in Chrome. Other browsers have not been tested but given that the requirement didn't exist in the spec previously it would be unsurprising if they lacked it as well.


Requirements for PR author:

Requirements for reviewer sign-off:

When landing this PR, be sure to make any necessary issue status updates.

lokokung commented 2 months ago

Agree that we should land this after the spec changes, but LGTM otherwise! Thanks for raising this Brandon!