search

gpuweb / cts

WebGPU Conformance Test Suite
https://gpuweb.github.io/cts/
BSD 3-Clause "New" or "Revised" License
121 stars 72 forks source link

Assert there are no uncaptured errors. #3753

Open sagudev opened 1 month ago

sagudev commented 1 month ago

In servo (https://github.com/servo/servo/pull/32304) I noticed that test could pass if errors we not caught by scopes (bad scopes impl; but they passed all error scope tests), so it might make sense to also assert on endTestScope that no uncaptured errors exists.

kainino0x commented 1 month ago

There's no way to reliably flush uncaptured errors. Best we could do is wait a bit and hope they flush.

Would it be possible to enhance the scope tests so they would have caught the issue?

sagudev commented 1 month ago

There's no way to reliably flush uncaptured errors. Best we could do is wait a bit and hope they flush.

Ah, you're right. I also se this in expectUncapturedError.

Would it be possible to enhance the scope tests so they would have caught the issue?

Will do.