Closed ErichDonGubler closed 1 month ago
Alternatively, we could make the diff a bit smaller by using a depth-stencil attachment instead:
@@ -265,7 +265,14 @@ g.test('wrappers_do_not_share_labels')
layout: 'auto',
vertex: {
module,
entryPoint: 'main',
},
+ // Specify a depth-stencil attachment so we have at least one render target. Not relevant to
+ // this test.
+ depthStencil: {
+ format: 'depth16unorm',
+ depthWriteEnabled: true,
+ depthCompare: 'equal',
+ },
});
const layout1 = pipeline.getBindGroupLayout(0);
…but the rgba8unorm
color attachment seems like established precedent elsewhere.
The GitHub settings require the PR branch to be up-to-date with main
before landing (because we have some things that are very prone to merge conflicts). Could you merge with main? Then once checks pass again, auto-merge should accept it.
Rebased!
CI's build
job appears to be still running (getting up to ~10m now), but previous runs are significantly shorter (i.e., the run in the pre-rebased branch tip ran in ~3.5m, main
's current tip reports a similar runtime for its CI). Also, the run in question seems to have not terminated still, despite all steps being reported as completed? 🤔 Is this a CI platform bug, maybe? See also the below screenshot.
ETA: Attempting to resolve this with a job restart.
Weird stuff like that happens from time to time. It seems to have eventually resolved itself though!
Or rather, it seems you resolved it by retrying :)
Issue: #3754
Requirements for PR author:
.unimplemented()
./** documented */
and new helper files are found inhelper_index.txt
.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.