gpuweb / cts

WebGPU Conformance Test Suite
https://gpuweb.github.io/cts/
BSD 3-Clause "New" or "Revised" License
121 stars 72 forks source link

fix: specify `rgba8unorm` render target for `webgpu:api,operation,labels:wrappers_do_not_share_labels:*` #3756

Closed ErichDonGubler closed 1 month ago

ErichDonGubler commented 1 month ago

Issue: #3754


Requirements for PR author:

Requirements for reviewer sign-off:

When landing this PR, be sure to make any necessary issue status updates.

ErichDonGubler commented 1 month ago

Alternatively, we could make the diff a bit smaller by using a depth-stencil attachment instead:

@@ -265,7 +265,14 @@ g.test('wrappers_do_not_share_labels')
       layout: 'auto',
       vertex: {
         module,
         entryPoint: 'main',
       },
+      // Specify a depth-stencil attachment so we have at least one render target. Not relevant to
+      // this test.
+      depthStencil: {
+        format: 'depth16unorm',
+        depthWriteEnabled: true,
+        depthCompare: 'equal',
+      },
     });
     const layout1 = pipeline.getBindGroupLayout(0);

…but the rgba8unorm color attachment seems like established precedent elsewhere.

kainino0x commented 1 month ago

The GitHub settings require the PR branch to be up-to-date with main before landing (because we have some things that are very prone to merge conflicts). Could you merge with main? Then once checks pass again, auto-merge should accept it.

ErichDonGubler commented 1 month ago

Rebased!

CI's build job appears to be still running (getting up to ~10m now), but previous runs are significantly shorter (i.e., the run in the pre-rebased branch tip ran in ~3.5m, main's current tip reports a similar runtime for its CI). Also, the run in question seems to have not terminated still, despite all steps being reported as completed? 🤔 Is this a CI platform bug, maybe? See also the below screenshot.

image

ETA: Attempting to resolve this with a job restart.

kainino0x commented 1 month ago

Weird stuff like that happens from time to time. It seems to have eventually resolved itself though!

kainino0x commented 1 month ago

Or rather, it seems you resolved it by retrying :)