Out-of-bounds textureStore tests

alan-baker commented 3 weeks ago

Checks that textureStore with out-of-bounds coordinates do not execute

Issue: #

Requirements for PR author:

[ ] All missing test coverage is tracked with "TODO" or .unimplemented().
[ ] New helpers are /** documented */ and new helper files are found in helper_index.txt.
[ ] Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
[ ] Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

[ ] Tests are properly located in the test tree.
[ ] Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
[ ] Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
[ ] Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

alan-baker commented 3 weeks ago

Couple bugs so far:

2D coordinates need fixed
mip copying is incorrect

alan-baker commented 2 weeks ago

Fixed the bugs. Still needs 2d-array and 3d tests, but confirmed these fail currently for tint and pass (locally) with a modified tint.

alan-baker commented 2 weeks ago

Functionality is complete now from my point of view.

kainino0x commented 2 weeks ago

Sorry for delayed response. My development time has been almost 100% on reviews for several months, so the few days I've been off recently have gotten me repeatedly behind on reviews.... @greggman any chance I could ask you to review this? I'll still review your PR since it's incremental on tests I've already been looking at.

kainino0x commented 2 weeks ago

(@alan-baker should this be taken out of draft state?)

alan-baker commented 2 weeks ago

(@alan-baker should this be taken out of draft state?)

Probably not until we merge https://github.com/gpuweb/gpuweb/pull/4194. Currently this is stricter than the spec.

alan-baker commented 2 weeks ago

Sorry for delayed response. My development time has been almost 100% on reviews for several months, so the few days I've been off recently have gotten me repeatedly behind on reviews.... @greggman any chance I could ask you to review this? I'll still review your PR since it's incremental on tests I've already been looking at.

I included you because you had commented on the WebGPU proposal. I can find other reviewers. It was more of an FYI.

greggman commented 2 weeks ago

I put up a PR for virtualMipSize here #3792

gpuweb / cts

Out-of-bounds textureStore tests #3781