Closed greggman closed 2 weeks ago
It wasn't clear if I should just put this test in error_scope.spec.ts or put it here where there was a TODO but technically this isn't error scope so ?
This seems fine, no strong feeling whether it should be in error_scope or not. Kinda ambiguous because it's part of the same system, sort of like the "catch-all" error scope, but since there might end up being other uncapturederror tests in this file someday, separate file makes enough sense.
LGTM but I think you forgot to upload src/webgpu/idl/constructable.spec.ts
src/webgpu/idl/constructable.spec.ts
already exists and already has a test that creates each error type and a GPUUncapturedErrorEvent
Oh, sorry, got it. LGTM then!
It wasn't clear if I should just put this test in error_scope.spec.ts or put it here where there was a TODO but technically this isn't error scope so ?
Also the constructor is tested in src/webgpu/idl/constructable.spec.ts
This came up because I was working on the webgpu-debug-helper and needed to test some stuff.
Requirements for PR author:
.unimplemented()
./** documented */
and new helper files are found inhelper_index.txt
.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.