gpuweb / cts

WebGPU Conformance Test Suite
https://gpuweb.github.io/cts/
BSD 3-Clause "New" or "Revised" License
121 stars 72 forks source link

Add uncapturederror test #3784

Closed greggman closed 2 weeks ago

greggman commented 2 weeks ago

It wasn't clear if I should just put this test in error_scope.spec.ts or put it here where there was a TODO but technically this isn't error scope so ?

Also the constructor is tested in src/webgpu/idl/constructable.spec.ts

This came up because I was working on the webgpu-debug-helper and needed to test some stuff.


Requirements for PR author:

Requirements for reviewer sign-off:

When landing this PR, be sure to make any necessary issue status updates.

kainino0x commented 2 weeks ago

It wasn't clear if I should just put this test in error_scope.spec.ts or put it here where there was a TODO but technically this isn't error scope so ?

This seems fine, no strong feeling whether it should be in error_scope or not. Kinda ambiguous because it's part of the same system, sort of like the "catch-all" error scope, but since there might end up being other uncapturederror tests in this file someday, separate file makes enough sense.

greggman commented 2 weeks ago

LGTM but I think you forgot to upload src/webgpu/idl/constructable.spec.ts

src/webgpu/idl/constructable.spec.ts already exists and already has a test that creates each error type and a GPUUncapturedErrorEvent

greggman commented 2 weeks ago

https://github.com/gpuweb/cts/blob/441db0a23175268d4a49310a9b4d2f0e3c15dc62/src/webgpu/idl/constructable.spec.ts#L48

kainino0x commented 2 weeks ago

Oh, sorry, got it. LGTM then!