search

gpuweb / cts

WebGPU Conformance Test Suite
https://gpuweb.github.io/cts/
BSD 3-Clause "New" or "Revised" License
127 stars 77 forks source link

`npm run wpt` generates `*.worker.js` tests that accidentally get run by `wptrunner` #3834

Closed ErichDonGubler closed 1 week ago

ErichDonGubler commented 2 months ago

*.worker.js files are included in out-wpt/ output generated by npm run wpt. This file extension appears to have been settled on in isolation from consideration of WPT tests, which actually treat *.worker.js files as a form of test specification (see WPT upstream docs' section titled "Dedicated worker tests (.worker.js)".

We need to move away from this file extension for worker tests that aren't intended to be run in WPT.

ErichDonGubler commented 2 months ago

@kainino0x suggested in a DM conversation with me that that it would be clearer to make a uniform change of file extension across all testing targets.

ErichDonGubler commented 2 months ago

Bug experience report: Mozilla has run into this in CI, and worked around this by marking these unintended test specs. as disabled: true in a __dir__.ini WPT metadata entry.

ErichDonGubler commented 3 weeks ago

This appears to not actually be solved yet; npm run wpt now generates *.as_worker.js tests in addition to (rather than instead of) the originally offending *.worker.js tests. 🤔

kainino0x commented 2 weeks ago

That's surprising as I don't see any *.worker.js in the build output at https://github.com/gpuweb/cts/tree/gh-pages/out-wpt/webgpu/webworker

Could you check that your build directory is getting wiped before build? Otherwise the old files could still be leftover.

ErichDonGubler commented 1 week ago

I was able to reproduce this on one of my machines for some time, but after updating to latest main and very forcibly using git clean -xdf, I believe I was running into local issues. Sorry for the noise!