search

gpuweb / cts

WebGPU Conformance Test Suite
https://gpuweb.github.io/cts/
BSD 3-Clause "New" or "Revised" License
132 stars 84 forks source link

`webgpu:shader,validation,parse,diagnostic:duplicate_attribute_same_location:*` expects failure when `s1` and `s2` are the same, but should succeed #4041

Closed ErichDonGubler closed 1 week ago

ErichDonGubler commented 1 week ago

According to the WGSL spec.:

Two diagnostic filters conflict when:

  • (AR1 = AR2), and

  • (TR1 = TR2), and

  • (NS1 ≠ NS2).

...where NS1 and NS2 correspond to the s1 and s2 matrix values in webgpu:shader,validation,parse,diagnostic:duplicate_attribute_same_location:*. This means that when s1 === s2 in the duplicate_attribute_same_location test, we should expect success, in addition to the cases already expected where same_rule === false.

alan-baker commented 1 week ago

The attribute has an additional rule:

More than one diagnostic attribute may be specified on a syntactic form, but they must specify different triggering rules.

So same severity is allowed for the global filter, but disallowed for attributes.

ErichDonGubler commented 1 week ago

Oof! My mistake, it seems. 😩 Thanks for the patient response.