search

gpuweb / cts

WebGPU Conformance Test Suite
https://gpuweb.github.io/cts/
BSD 3-Clause "New" or "Revised" License
132 stars 84 forks source link

Add MaxLimitsTest that sets all limits to the adapter's #4059

Closed greggman closed 1 day ago

greggman commented 4 days ago

This is what I came up with. Without a major refactor the issue is the adapter is requested at an extremely low level but a test needs access to an adapter to select limits.

So, made selectDeviceOrSkipTestCase pass an optional callback all the way down that gets passed the adapter and a CanonicalDeviceDescriptor, giving it a chance to modify it down at the level where an adapter is available.

More of the CTS tests need to be testing with max limits.

Issue: #3363

greggman commented 4 days ago

Note: This test fails in Chrome because of the origin trial for subgroups.

It fails with

WebGPU device failed to initialize with OperationError "Failed to execute 'requestDevice' on 'GPUAdapter': The limit "minSubgroupSize" is not recognized."

I don't think the test should change and I think it should be a high-priority for Chrome not to fail if you request all the limits by copying them