search

gpuweb / gpuweb

Where the GPU for the Web work happens!
http://webgpu.io
Other
4.75k stars 314 forks source link

Spec web page word highlight feature has low contrast in dark mode #4598

Open greggman opened 4 months ago

greggman commented 4 months ago

Some feature of the spec web page seems to highlight words clicked on, but those words have low-contrast in dark mode

Screenshot 2024-04-24 at 16 03 04

related: https://github.com/gpuweb/gpuweb/issues/3649

greggman commented 4 months ago

adding

@media (prefers-color-scheme: dark) {
  var[data-var-color] {
     color: black;
     filter: invert(1);
  }
}

Might solve it.

Screenshot 2024-04-24 at 16 21 40
kainino0x commented 4 months ago

Don't think we're using any custom styling here, so this is a Bikeshed issue. Found https://github.com/speced/bikeshed/issues/2157

litherum commented 4 months ago

Should this issue be closed and marked as "moved?"

kainino0x commented 4 months ago

I think I'd like to keep it open here since it's still an active problem with our spec. Maybe one of us will go contribute a fix to Bikeshed (or make a quick patch in our spec, though fixing bikeshed shouldn't be hard)

greggman commented 1 month ago

I put up a PR for bikeshed. No comment on why it has not been accepted

https://github.com/speced/bikeshed/pull/2848