search

gpuweb / types

TypeScript type definitions for WebGPU https://gpuweb.github.io/types/
https://www.npmjs.com/package/@webgpu/types
BSD 3-Clause "New" or "Revised" License
181 stars 38 forks source link

move typescript to devDependencies #117

Closed greggman closed 1 year ago

greggman commented 1 year ago

I'm assuming it wasn't intentional to make every downstream project install typescript

lokokung commented 1 year ago

Oh hmm... I probably have something messed up that I don't understand in npm... I did this typescript version rollback in another repository but not sure how it got into this one... Thanks for the catch...

Separately, though, is there a reason to use 4.9.4? I think I ran into issues with it in https://github.com/gpuweb/types/pull/116 which is the repository and PR where I tried to revert to 4.6.4. Otherwise feel free to merge!

greggman commented 1 year ago

If we need 4.6.4 then the package.json needs to say 

   "typescript": "4.6.4"

not

  "typescript": "^4.6.4"

notice the ^. That means anything newer than 4.6.4 is fine but not 5.x.x. So 4.9.4 fits what's specified in the file.

I changed it to 4.6.4 from ^4.6.4

kainino0x commented 1 year ago

published 0.1.26