ElliottMess commented 2 years ago

/document

Fix problem identified in issue #35 where fh was not transformed in transform_uhc_data but in calculated_uhc_billion. This lead to an error in the calculations of the contributions of fh to the billion: all contributions were reversed.

Waiting for the approval of PR #38 and #40 to merge.

Once merged into main, the testing data frames will need to be recalculated and reuploaded to WHDH.

ElliottMess commented 2 years ago

/style

codecov-commenter commented 2 years ago

Codecov Report

Merging #42 (48b4d73) into main (aeeb6a5) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head 48b4d73 differs from pull request most recent head 4e25a1a. Consider uploading reports for the commit 4e25a1a to get more accurate results

@@           Coverage Diff           @@
##             main      #42   +/-   ##
=======================================
  Coverage   84.03%   84.03%           
=======================================
  Files          37       37           
  Lines        3858     3858           
=======================================
  Hits         3242     3242           
  Misses        616      616

Impacted Files	Coverage Δ
R/calculate_uhc_billion.R	`100.00% <100.00%> (ø)`
R/transform_uhc.R	`66.03% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update aeeb6a5...4e25a1a. Read the comment docs.

gpw13 / billionaiRe

Fix problem with `fh` transformation #42

Codecov Report