gpw13 / billionaiRe

Calculate the WHO Triple Billions
https://gpw13.github.io/billionaiRe/
GNU General Public License v3.0
7 stars 4 forks source link

load_billion_data introduced by PR #39 is not retro-compatible #45

Closed ElliottMess closed 1 year ago

ElliottMess commented 2 years ago

The new WHDH powered load_billion_data introduced by PR #39 is not compatible with the previous version. This means that all calls to the function in old call with fail as the tables are not available anymore. There is a fundamental data compability issue that renders the changes difficult to retro-fit. So for now, a _legacy functions allows to get the data from xMart.

The situation could be reversed and have the _whdh function with a possible lifecylce notification on both functions to indicate that the xmart version will be retired.

@alicerobson what do you think?