gpw13 / billionaiRe

Calculate the WHO Triple Billions
https://gpw13.github.io/billionaiRe/
GNU General Public License v3.0
7 stars 4 forks source link

Remove fixed column names from parameters #59

Closed ElliottMess closed 2 years ago

ElliottMess commented 2 years ago

Instead of having multiple arguments like ind_col = "ind", only the value, transform_value and scenario and related indicators. They are also renamed with consistent naming convention: value_col, transform_value_col , and scenario_col.

see #57

ElliottMess commented 2 years ago

Task linked: CU-2td233q Remove unhelpful column names from billionaiRe

codecov-commenter commented 2 years ago

Codecov Report

Merging #59 (f7d88f6) into main (588ae4e) will decrease coverage by 0.19%. The diff coverage is 93.41%.

@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
- Coverage   88.25%   88.06%   -0.20%     
==========================================
  Files          44       44              
  Lines        4718     4657      -61     
==========================================
- Hits         4164     4101      -63     
- Misses        554      556       +2     
Impacted Files Coverage Δ
R/calculate_contribution_sums.R 0.00% <0.00%> (ø)
R/data_access.R 60.97% <0.00%> (-1.53%) :arrow_down:
R/extrapolate_campaign_data.R 33.33% <0.00%> (-0.96%) :arrow_down:
R/remove_recycled_data.R 0.00% <0.00%> (ø)
R/transform_hpop.R 64.00% <48.27%> (-1.39%) :arrow_down:
R/transform_uhc.R 70.68% <63.15%> (+4.65%) :arrow_up:
R/utils_asserts.R 61.92% <63.41%> (+2.66%) :arrow_up:
R/add_scenarios.R 97.91% <80.00%> (-0.05%) :arrow_down:
R/assert_data_calculations.R 63.73% <81.57%> (+1.23%) :arrow_up:
R/scenarios_specific_scenarios.R 90.90% <88.00%> (-0.17%) :arrow_down:
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 588ae4e...f7d88f6. Read the comment docs.