Open bpecsek opened 2 years ago
Hi Bela,
No, I was not aware of these patches. I will look into them.
Thanks,
--george
On Jun 30, 2022, at 4:58 AM, Bela Pecsek @.***> wrote:
Hi there,
I am just wandering if the patches related to inter pattern matches in https://sourceforge.net/p/lisa/bugs/18/ https://sourceforge.net/p/lisa/bugs/18/ has been included in this fork.
Kind Regards, Bela
— Reply to this email directly, view it on GitHub https://github.com/gpwwjr/LISA/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKJWCNF5JSJ7JC33P6ELZZ3VRVVU5ANCNFSM52IX6PYQ. You are receiving this because you are subscribed to this thread.
Hi George,
Are you planning to integrate the patches in your repository?
Kindest Regards, Bela
I have sent a PR with the fixes
I would like to. Do you know why the patches were never accepted for incorporation into lisa 3.2?
On Jul 2, 2022, at 5:21 AM, Bela Pecsek @.***> wrote:
Hi George,
Are you planning to integrate the patches in your repository?
Kindest Regards, Bela
— Reply to this email directly, view it on GitHub https://github.com/gpwwjr/LISA/issues/1#issuecomment-1172874816, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKJWCNEKJZGZUFZN52LDXBTVSAJZLANCNFSM52IX6PYQ. You are receiving this because you commented.
As far as I know the maintainer stopped maintaining it but I might be wrong.
Do you have any idea how to contact the original author of this patch (Aneil Mallavarapu)?
On Jul 2, 2022, at 4:01 PM, Bela Pecsek @.***> wrote:
As far as I know the maintainer stopped maintaining it but I might be wrong.
— Reply to this email directly, view it on GitHub https://github.com/gpwwjr/LISA/issues/1#issuecomment-1172959814, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKJWCNETSVJTSWTXUFANLMTVSCUZTANCNFSM52IX6PYQ. You are receiving this because you commented.
Any success contacting Aneil?
Unfortunately, no.
On Jul 15, 2022, at 12:56 AM, Bela Pecsek @.***> wrote:
Any success contacting Aneil?
— Reply to this email directly, view it on GitHub https://github.com/gpwwjr/LISA/issues/1#issuecomment-1185201785, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKJWCNFRDM4JUGOOLMWS6LLVUD4SVANCNFSM52IX6PYQ. You are receiving this because you commented.
Please try this code with and without the inter pattern filter patch to see the enormous improvement.
(ql:quickload :lisa)
(in-package :lisa-user)
(defclass x () ((a :initarg :a)))
(defclass y () ((b :initarg :b)))
(defrule match ()
(x (a ?v))
(y (b ?v))
=>
(format t "+"))
(defun test (n)
(declare (optimize speed (safety 0) (debug 0)))
"Times the matching of n instances"
(reset)
(dotimes (i n)
(assert-instance (make-instance 'x :a i))
(assert-instance (make-instance 'y :b i)))
(run))
(time (test 10000))
Hi there,
I am just wandering if the patches related to inter pattern matches in https://sourceforge.net/p/lisa/bugs/18/ has been included in this fork.
Kind Regards, Bela