search

gql-dart / gql

Libraries supporting GraphQL in Dart
MIT License
267 stars 121 forks source link

Upgrade to web_socket_channel 3.0.0 #462

Open catapop84 opened 3 months ago

catapop84 commented 3 months ago

This PR will upgrade to web_socket_channel 3.0.0

knaeckeKami commented 3 months ago

Thanks! It seems like there have been some changes in behavior, since a few tests fail

catapop84 commented 3 months ago

Hello @knaeckeKami, I saw. Trying to fix it. :)

catapop84 commented 3 months ago

@knaeckeKami , On my local pc test is valid. I'm using Dart SDK version: 3.4.1 (stable). That error might be from sdk. Can you check?

knaeckeKami commented 3 months ago

It fails on the format check. Please try executing dart format with

Dart SDK version: 3.4.0 (stable)

catapop84 commented 3 months ago

@knaeckeKami I did format. it fails on auto reconnect. not sure why because on my local comp. is working. It's probably an OS problem. I'll test it on linux when I get home to further investigate the problem.

❌ test/gql_websocket_link_test.dart: WebSocketLink transport ws sub-protocol Auto reconnect (failed) ❌ test/gql_websocket_link_test.dart: WebSocketLink transport ws sub-protocol Auto reconnect (failed after test completion)

knaeckeKami commented 3 months ago

FWIW it also fails locally for me, in MacOS

knaeckeKami commented 2 months ago

possibly related: https://github.com/dart-lang/web_socket_channel/pull/370