Version Packages

[github-actions[bot]]

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@gqty/cli@4.1.2

Patch Changes

• #2000 fc1155f Thanks @lubosmato! - Allow watch targets above current working directory

[lubosmato]

@vicary can we merge this or is there anything else that should be tested/checked?

[vicary]

@lubosmato If you think the current main works as intended, we are good to go.

[lubosmato]

I tested these cases.

Working correctly:

• Wildcard unquoted
  • yarn gqty --react --no-subscriptions --target=./generated/gqty.ts --typescript --no-install --watch ../api/*.graphql
  • This way shell resolves wildcards in file paths
• Wildcard with quotes
  • yarn gqty --react --no-subscriptions --target=./generated/gqty.ts --typescript --no-install --watch "../api/*.graphql"
  • Shell is not resolving wildcards
• Schema in cwd
  • yarn gqty --react --no-subscriptions --target=./generated/gqty.ts --typescript --no-install --watch schema.graphql
• Watch in vim editor
  • vim editor saves files a bit differently
  • file watch events weren't picked up previously
  • https://www.jaykim.earth/posts/2023-06-28-gotchas-using-fs-watch-with-vim
• Glob pattern (double wildcard) unquoted
  • yarn gqty --react --no-subscriptions --target=./generated/gqty.ts --typescript --no-install --watch ../api/**/*.graphql
  • This way shell resolves wildcards in file paths

Throws an error:

• Glob pattern (double wildcard) with quotes
  • yarn gqty --react --no-subscriptions --target=./generated/gqty.ts --typescript --no-install --watch "../api/**/*.graphql"
  • Shell is not resolving wildcards
  • Error: ENOENT: no such file or directory, watch '...(redacted).../apps/api/**'
  • In previous version this is working in current working directory
  • I tend to think this is an an edge case and solution could be to use unquoted paths so shell would resolve glob patterns.

Let me know if it is worth to focus on the Glob pattern with quotes or we can merge.

[vicary]

@lubosmato Thanks for the extensive testing.

To qualify as a patch upgrade, we should try to retain previous behaviours. Fortunately CLI already has fast-glob so we don't have to introduce another new dependency.

I made some changes to main, see if 6bbdce83 checks everything on your list?

[lubosmato]

@vicary Thank you for taking care of the glob pattern.

Tested again and found that glob pattern does not pick up some changes.

CWD: apps/web/

Pattern is "../api/**/*.graphql"

Folder structure:

.
└── apps/
    ├── api/
    │   ├── sub/
    │   │   └── schema.graphql
    │   └── schema.graphql
    └── web (cwd)

Only apps/api/schema.graphql changes are picked up.

Not sure why at the moment. Will check the issue later today.

[vicary]

@lubosmato Basically map( pipeAsync() ) with flat() cuts off the iterable at the first match, do you think it's possible to do it without iter-ops?

[lubosmato]

Yeah, working on it.

[vicary]

@lubosmato Looking at the diff reminds me of the fact that we were watching recursively.

Shallow watches on the immediate directories would ignore nested directories created after the watcher is started.

I can think of two options at the moment,

1. Running the watcher at your project root as a workaround,
2. Expose a new CLI option as a watch target with cwd as a default.

wdyt?

[lubosmato]

I tried again to combine those pesky AsyncIterators and realized that this is a bit rabbit hole 😅 . The simplest approach could be watching recursively the top-most directory based on input endpoints.

E.g. ../api/**/*.graphql ../api2/**/*.graphql ./local.graphql would do single recursive watch on $PWD/../.

[lubosmato]

@vicary Let's revert my changes so we don't block release process and I will prepare a new MR with single recursive watch if you aggree.

[lubosmato]

@vicary The simplest approach implemented here and without any additional dependencies: https://github.com/gqty-dev/gqty/pull/2000

Thank you for your time and help with this fix.