search

gquintard / varnish-rs

Rust bindings for the Varnish Cache project
BSD 3-Clause "New" or "Revised" License
22 stars 4 forks source link

Consider merging varnish-sys into varnish crate #32

Closed nyurik closed 2 months ago

nyurik commented 2 months ago

This is more of a question - would it make sense to merge -sys into the main crate? It seems most of its content is auto-generated anyway, so might as well just move the build.rs to the root? I think -sys creates mostly exist only when they are being maintained separately by hand, rather than being auto-genned.

gquintard commented 2 months ago

what I've seen, it's customary to have two crates, notable in case someone doesn't want to embark the manually crafted bindings, so I would lean towards no, but I'm open to discussions

nyurik commented 2 months ago

Hi, thx for replying. I am not certain I understood what you meant. Most of the -sys crates I have seen are all manually maintained. I haven't yet seen a single one (i'm sure they exist) - that is fully auto-generated, esp when only used by one other crate. Having two crates is tricky to manage, esp because crates.io does not yet support multi-crate publishing.

gquintard commented 2 months ago

that's a good data, I had a cursory look a while back and understood that the C interfaces where usually isolated in a -sys crate, but maybe we can just use a module and be done with it.

it's not a priority, but if you want to merge them, I'm not against it

gquintard commented 2 months ago

done through #34