search

gr2m / hapi-cors-headers

hapi extension to enable CORS
MIT License
28 stars 11 forks source link

Fixed for Hapi 17+ #23

Open bloodf opened 5 years ago

ci-reporter[bot] commented 5 years ago

The build is failing

✨ Good work on this PR so far! ✨ Unfortunately, the Travis CI build is failing as of e960ab1d00f8514d35a99a21d49879536b575039. Here's the output:

npm test
> hapi-cors-headers@ pretest /home/travis/build/gr2m/hapi-cors-headers
> standard

> hapi-cors-headers@ test /home/travis/build/gr2m/hapi-cors-headers
> tap --100 --coverage tests

tests/index.js ...................................... 14/18
  request.headers.origin is undefined
  not ok reply.continue called
    +++ found                                                           
    --- wanted                                                          
    -true                                                               
    +false                                                              
    compare: ===
    at:
      line: 1
      column: 5409
      file: tests/index.js
      type: Test
    stack: >
      Test.<anonymous> (tests/index.js:1:5409)

      Object.<anonymous> (tests/index.js:1:4954)

      Object.<anonymous> (node_modules/esm/esm.js:1:227183)

      node_modules/esm/esm.js:1:222656

      Generator.next (<anonymous>)

      cu (node_modules/esm/esm.js:1:223009)

      yu (node_modules/esm/esm.js:1:225201)

      p (node_modules/esm/esm.js:1:261393)

      node_modules/esm/esm.js:1:260750

      node_modules/esm/esm.js:1:258671

      Object.apply (node_modules/esm/esm.js:1:182783)

      Object.<anonymous>
      (node_modules/nyc/node_modules/append-transform/index.js:62:4)

      node_modules/esm/esm.js:1:211446

      node_modules/esm/esm.js:1:211481

      node_modules/esm/esm.js:1:211686

      yl (node_modules/esm/esm.js:1:209574)

      wl (node_modules/esm/esm.js:1:210888)

      gc (node_modules/esm/esm.js:1:233442)

      Proxy.<anonymous> (node_modules/esm/esm.js:1:268669)

      Proxy.<anonymous> (node_modules/esm/esm.js:1:268478)

      Proxy.<anonymous> (node_modules/esm/esm.js:1:258671)

      Object.apply (node_modules/esm/esm.js:1:182783)

      Object.<anonymous> (node_modules/nyc/bin/wrap.js:23:4)

      Object.<anonymous> (node_modules/esm/esm.js:1:227183)

      node_modules/esm/esm.js:1:222656

      Generator.next (<anonymous>)

      cu (node_modules/esm/esm.js:1:223009)

      yu (node_modules/esm/esm.js:1:225201)

      Object.p (node_modules/esm/esm.js:1:261393)

      Object.<anonymous> (node_modules/esm/esm.js:1:260750)

      Object.<anonymous> (node_modules/esm/esm.js:1:258671)

      Object.apply (node_modules/esm/esm.js:1:182783)

      node_modules/esm/esm.js:1:211446

      node_modules/esm/esm.js:1:211481

      node_modules/esm/esm.js:1:211686

      yl (node_modules/esm/esm.js:1:209574)

      wl (node_modules/esm/esm.js:1:210888)

      gc (node_modules/esm/esm.js:1:233442)

      Proxy.<anonymous> (node_modules/esm/esm.js:1:268669)

      Proxy.<anonymous> (node_modules/esm/esm.js:1:268478)

      Proxy.<anonymous> (node_modules/esm/esm.js:1:258671)

      Object.apply (node_modules/esm/esm.js:1:182783)

      Object.<anonymous> (node_modules/esm/esm.js:1:227183)

      node_modules/esm/esm.js:1:222656

      Generator.next (<anonymous>)

      cu (node_modules/esm/esm.js:1:223009)

      yu (node_modules/esm/esm.js:1:225201)

      Object.p (node_modules/esm/esm.js:1:261393)

      Object.<anonymous> (node_modules/esm/esm.js:1:260750)

      Object.<anonymous> (node_modules/esm/esm.js:1:258671)

      Object.apply (node_modules/esm/esm.js:1:182783)

      node_modules/esm/esm.js:1:211446

      node_modules/esm/esm.js:1:211481

      node_modules/esm/esm.js:1:211686

      yl (node_modules/esm/esm.js:1:209574)

      wl (node_modules/esm/esm.js:1:210888)

      gc (node_modules/esm/esm.js:1:233442)

      Function.<anonymous> (node_modules/esm/esm.js:1:268669)

      Function.<anonymous> (node_modules/esm/esm.js:1:268478)

      Function.<anonymous> (node_modules/esm/esm.js:1:258671)

      Object.apply (node_modules/esm/esm.js:1:182783)
    source: >
      (function (exports, require, module, __filename, __dirname) { var test =
      require('tap').test

  request is boom error
  not ok reply.continue called
    +++ found                                                           
    --- wanted                                                          
    -true                                                               
    +false                                                              
    compare: ===
    at:
      line: 1
      column: 6339
      file: tests/index.js
      type: Test
    stack: >
      Test.<anonymous> (tests/index.js:1:6339)

      Object.<anonymous> (tests/index.js:1:5517)

      Object.<anonymous> (node_modules/esm/esm.js:1:227183)

      node_modules/esm/esm.js:1:222656

      Generator.next (<anonymous>)

      cu (node_modules/esm/esm.js:1:223009)

      yu (node_modules/esm/esm.js:1:225201)

      p (node_modules/esm/esm.js:1:261393)

      node_modules/esm/esm.js:1:260750

      node_modules/esm/esm.js:1:258671

      Object.apply (node_modules/esm/esm.js:1:182783)

      Object.<anonymous>
      (node_modules/nyc/node_modules/append-transform/index.js:62:4)

      node_modules/esm/esm.js:1:211446

      node_modules/esm/esm.js:1:211481

      node_modules/esm/esm.js:1:211686

      yl (node_modules/esm/esm.js:1:209574)

      wl (node_modules/esm/esm.js:1:210888)

      gc (node_modules/esm/esm.js:1:233442)

      Proxy.<anonymous> (node_modules/esm/esm.js:1:268669)

      Proxy.<anonymous> (node_modules/esm/esm.js:1:268478)

      Proxy.<anonymous> (node_modules/esm/esm.js:1:258671)

      Object.apply (node_modules/esm/esm.js:1:182783)

      Object.<anonymous> (node_modules/nyc/bin/wrap.js:23:4)

      Object.<anonymous> (node_modules/esm/esm.js:1:227183)

      node_modules/esm/esm.js:1:222656

      Generator.next (<anonymous>)

      cu (node_modules/esm/esm.js:1:223009)

      yu (node_modules/esm/esm.js:1:225201)

      Object.p (node_modules/esm/esm.js:1:261393)

      Object.<anonymous> (node_modules/esm/esm.js:1:260750)

      Object.<anonymous> (node_modules/esm/esm.js:1:258671)

      Object.apply (node_modules/esm/esm.js:1:182783)

      node_modules/esm/esm.js:1:211446

      node_modules/esm/esm.js:1:211481

      node_modules/esm/esm.js:1:211686

      yl (node_modules/esm/esm.js:1:209574)

      wl (node_modules/esm/esm.js:1:210888)

      gc (node_modules/esm/esm.js:1:233442)

      Proxy.<anonymous> (node_modules/esm/esm.js:1:268669)

      Proxy.<anonymous> (node_modules/esm/esm.js:1:268478)

      Proxy.<anonymous> (node_modules/esm/esm.js:1:258671)

      Object.apply (node_modules/esm/esm.js:1:182783)

      Object.<anonymous> (node_modules/esm/esm.js:1:227183)

      node_modules/esm/esm.js:1:222656

      Generator.next (<anonymous>)

      cu (node_modules/esm/esm.js:1:223009)

      yu (node_modules/esm/esm.js:1:225201)

      Object.p (node_modules/esm/esm.js:1:261393)

      Object.<anonymous> (node_modules/esm/esm.js:1:260750)

      Object.<anonymous> (node_modules/esm/esm.js:1:258671)

      Object.apply (node_modules/esm/esm.js:1:182783)

      node_modules/esm/esm.js:1:211446

      node_modules/esm/esm.js:1:211481

      node_modules/esm/esm.js:1:211686

      yl (node_modules/esm/esm.js:1:209574)

      wl (node_modules/esm/esm.js:1:210888)

      gc (node_modules/esm/esm.js:1:233442)

      Function.<anonymous> (node_modules/esm/esm.js:1:268669)

      Function.<anonymous> (node_modules/esm/esm.js:1:268478)

      Function.<anonymous> (node_modules/esm/esm.js:1:258671)

      Object.apply (node_modules/esm/esm.js:1:182783)
    source: >
      (function (exports, require, module, __filename, __dirname) { var test =
      require('tap').test

  options request without acces-control-request headers
  not ok reply.continue called
    +++ found                                                           
    --- wanted                                                          
    -true                                                               
    +false                                                              
    compare: ===
    at:
      line: 1
      column: 7561
      file: tests/index.js
      type: Test
    stack: >
      Test.<anonymous> (tests/index.js:1:7561)

      Object.<anonymous> (tests/index.js:1:6447)

      Object.<anonymous> (node_modules/esm/esm.js:1:227183)

      node_modules/esm/esm.js:1:222656

      Generator.next (<anonymous>)

      cu (node_modules/esm/esm.js:1:223009)

      yu (node_modules/esm/esm.js:1:225201)

      p (node_modules/esm/esm.js:1:261393)

      node_modules/esm/esm.js:1:260750

      node_modules/esm/esm.js:1:258671

      Object.apply (node_modules/esm/esm.js:1:182783)

      Object.<anonymous>
      (node_modules/nyc/node_modules/append-transform/index.js:62:4)

      node_modules/esm/esm.js:1:211446

      node_modules/esm/esm.js:1:211481

      node_modules/esm/esm.js:1:211686

      yl (node_modules/esm/esm.js:1:209574)

      wl (node_modules/esm/esm.js:1:210888)

      gc (node_modules/esm/esm.js:1:233442)

      Proxy.<anonymous> (node_modules/esm/esm.js:1:268669)

      Proxy.<anonymous> (node_modules/esm/esm.js:1:268478)

      Proxy.<anonymous> (node_modules/esm/esm.js:1:258671)

      Object.apply (node_modules/esm/esm.js:1:182783)

      Object.<anonymous> (node_modules/nyc/bin/wrap.js:23:4)

      Object.<anonymous> (node_modules/esm/esm.js:1:227183)

      node_modules/esm/esm.js:1:222656

      Generator.next (<anonymous>)

      cu (node_modules/esm/esm.js:1:223009)

      yu (node_modules/esm/esm.js:1:225201)

      Object.p (node_modules/esm/esm.js:1:261393)

      Object.<anonymous> (node_modules/esm/esm.js:1:260750)

      Object.<anonymous> (node_modules/esm/esm.js:1:258671)

      Object.apply (node_modules/esm/esm.js:1:182783)

      node_modules/esm/esm.js:1:211446

      node_modules/esm/esm.js:1:211481

      node_modules/esm/esm.js:1:211686

      yl (node_modules/esm/esm.js:1:209574)

      wl (node_modules/esm/esm.js:1:210888)

      gc (node_modules/esm/esm.js:1:233442)

      Proxy.<anonymous> (node_modules/esm/esm.js:1:268669)

      Proxy.<anonymous> (node_modules/esm/esm.js:1:268478)

      Proxy.<anonymous> (node_modules/esm/esm.js:1:258671)

      Object.apply (node_modules/esm/esm.js:1:182783)

      Object.<anonymous> (node_modules/esm/esm.js:1:227183)

      node_modules/esm/esm.js:1:222656

      Generator.next (<anonymous>)

      cu (node_modules/esm/esm.js:1:223009)

      yu (node_modules/esm/esm.js:1:225201)

      Object.p (node_modules/esm/esm.js:1:261393)

      Object.<anonymous> (node_modules/esm/esm.js:1:260750)

      Object.<anonymous> (node_modules/esm/esm.js:1:258671)

      Object.apply (node_modules/esm/esm.js:1:182783)

      node_modules/esm/esm.js:1:211446

      node_modules/esm/esm.js:1:211481

      node_modules/esm/esm.js:1:211686

      yl (node_modules/esm/esm.js:1:209574)

      wl (node_modules/esm/esm.js:1:210888)

      gc (node_modules/esm/esm.js:1:233442)

      Function.<anonymous> (node_modules/esm/esm.js:1:268669)

      Function.<anonymous> (node_modules/esm/esm.js:1:268478)

      Function.<anonymous> (node_modules/esm/esm.js:1:258671)

      Object.apply (node_modules/esm/esm.js:1:182783)
    source: >
      (function (exports, require, module, __filename, __dirname) { var test =
      require('tap').test

  options request
  not ok reply.continue called
    +++ found                                                           
    --- wanted                                                          
    -true                                                               
    +false                                                              
    compare: ===
    at:
      line: 1
      column: 8814
      file: tests/index.js
      type: Test
    stack: >
      Test.<anonymous> (tests/index.js:1:8814)

      Object.<anonymous> (tests/index.js:1:7669)

      Object.<anonymous> (node_modules/esm/esm.js:1:227183)

      node_modules/esm/esm.js:1:222656

      Generator.next (<anonymous>)

      cu (node_modules/esm/esm.js:1:223009)

      yu (node_modules/esm/esm.js:1:225201)

      p (node_modules/esm/esm.js:1:261393)

      node_modules/esm/esm.js:1:260750

      node_modules/esm/esm.js:1:258671

      Object.apply (node_modules/esm/esm.js:1:182783)

      Object.<anonymous>
      (node_modules/nyc/node_modules/append-transform/index.js:62:4)

      node_modules/esm/esm.js:1:211446

      node_modules/esm/esm.js:1:211481

      node_modules/esm/esm.js:1:211686

      yl (node_modules/esm/esm.js:1:209574)

      wl (node_modules/esm/esm.js:1:210888)

      gc (node_modules/esm/esm.js:1:233442)

      Proxy.<anonymous> (node_modules/esm/esm.js:1:268669)

      Proxy.<anonymous> (node_modules/esm/esm.js:1:268478)

      Proxy.<anonymous> (node_modules/esm/esm.js:1:258671)

      Object.apply (node_modules/esm/esm.js:1:182783)

      Object.<anonymous> (node_modules/nyc/bin/wrap.js:23:4)

      Object.<anonymous> (node_modules/esm/esm.js:1:227183)

      node_modules/esm/esm.js:1:222656

      Generator.next (<anonymous>)

      cu (node_modules/esm/esm.js:1:223009)

      yu (node_modules/esm/esm.js:1:225201)

      Object.p (node_modules/esm/esm.js:1:261393)

      Object.<anonymous> (node_modules/esm/esm.js:1:260750)

      Object.<anonymous> (node_modules/esm/esm.js:1:258671)

      Object.apply (node_modules/esm/esm.js:1:182783)

      node_modules/esm/esm.js:1:211446

      node_modules/esm/esm.js:1:211481

      node_modules/esm/esm.js:1:211686

      yl (node_modules/esm/esm.js:1:209574)

      wl (node_modules/esm/esm.js:1:210888)

      gc (node_modules/esm/esm.js:1:233442)

      Proxy.<anonymous> (node_modules/esm/esm.js:1:268669)

      Proxy.<anonymous> (node_modules/esm/esm.js:1:268478)

      Proxy.<anonymous> (node_modules/esm/esm.js:1:258671)

      Object.apply (node_modules/esm/esm.js:1:182783)

      Object.<anonymous> (node_modules/esm/esm.js:1:227183)

      node_modules/esm/esm.js:1:222656

      Generator.next (<anonymous>)

      cu (node_modules/esm/esm.js:1:223009)

      yu (node_modules/esm/esm.js:1:225201)

      Object.p (node_modules/esm/esm.js:1:261393)

      Object.<anonymous> (node_modules/esm/esm.js:1:260750)

      Object.<anonymous> (node_modules/esm/esm.js:1:258671)

      Object.apply (node_modules/esm/esm.js:1:182783)

      node_modules/esm/esm.js:1:211446

      node_modules/esm/esm.js:1:211481

      node_modules/esm/esm.js:1:211686

      yl (node_modules/esm/esm.js:1:209574)

      wl (node_modules/esm/esm.js:1:210888)

      gc (node_modules/esm/esm.js:1:233442)

      Function.<anonymous> (node_modules/esm/esm.js:1:268669)

      Function.<anonymous> (node_modules/esm/esm.js:1:268478)

      Function.<anonymous> (node_modules/esm/esm.js:1:258671)

      Object.apply (node_modules/esm/esm.js:1:182783)
    source: >
      (function (exports, require, module, __filename, __dirname) { var test =
      require('tap').test

total ............................................... 14/18

  14 passing (2s)
  4 failing

ERROR: Coverage for lines (93.75%) does not meet global threshold (100%)
ERROR: Coverage for functions (55.56%) does not meet global threshold (100%)
ERROR: Coverage for statements (93.75%) does not meet global threshold (100%)
-------------------------|----------|----------|----------|----------|-------------------|
File                     |  % Stmts | % Branch |  % Funcs |  % Lines | Uncovered Line #s |
-------------------------|----------|----------|----------|----------|-------------------|
All files                |    93.75 |      100 |    55.56 |    93.75 |                   |
 hapi-cors-headers       |      100 |      100 |      100 |      100 |                   |
  index.js               |      100 |      100 |      100 |      100 |                   |
 hapi-cors-headers/tests |    91.67 |      100 |       50 |    91.67 |                   |
  index.js               |    91.67 |      100 |       50 |    91.67 |       11,36,61,89 |
-------------------------|----------|----------|----------|----------|-------------------|

I'm sure you can fix it! If you need help, don't hesitate to ask a maintainer of the project!

This comment was automagically generated by ci-reporter. If you see a problem, open an issue here.
bloodf commented 5 years ago

In the same code is not possible.

The API has changed.

You will need to release a new version for 17+