Changed comparison of possible initials to duplicate initials

gr2m / initials

extract initials from and add initials to names

https://gr2m.github.io/initials

MIT License

44 stars 14 forks source link

Changed comparison of possible initials to duplicate initials #15

Closed sylvesterwillis closed 9 years ago

sylvesterwillis commented 9 years ago

Changed comparison of possible initials to duplicate initials to loop in reverse for array slicing.

sylvesterwillis commented 9 years ago

This PR is for https://github.com/gr2m/initials/issues/14.

gr2m commented 9 years ago

I think the change is good either way and I would go ahead and merge it, even though it does not yet resolve #14. But the fact that we currently slice out items of an array while iterating over it incrementally is definitely wrong.